feat(core): ground work for query cancellation + PostgreSQL implementation. #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
igalklebanov
force-pushed
the
cancelation-p1
branch
from
a3d18c9 to
627be4a
Compare
igalklebanov
added
enhancement
igalklebanov
force-pushed
the
cancelation-p1
branch
from
cbd6804 to
5e75c61
Compare
igalklebanov
force-pushed
the
cancelation-p1
branch
from
5e75c61 to
10d619b
Compare
igalklebanov
force-pushed
the
cancelation-p1
branch
from
d51f3a3 to
98dd794
Compare
igalklebanov
force-pushed
the
cancelation-p1
branch
from
9f663a3 to
521e2e3
Compare
Co-authored-by: Eric So <56284867+ericsodev@users.noreply.github.com> Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
…ely-org#1516) Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
…fier (kysely-org#1615) Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
apply executable @ select. test suite prep. ?? best bench results. ... update qb. merge qb. insert qb. delete qb. kysely. raw builder. fix regression in takeFirst. more core. abort. ... ... ... ... ... ... ... ... ... executeQuery. ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...
igalklebanov
force-pushed
the
cancelation-p1
branch
from
3ecc532 to
70da7fc
Compare
igalklebanov
force-pushed
the
cancelation-p1
branch
from
cab8d72 to
285a816
Compare
igalklebanov
force-pushed
the
next
branch
2 times, most recently
from
f257ae4 to
c85d7c2
Compare
igalklebanov
force-pushed
the
next
branch
2 times, most recently
from
06eca6f to
500a250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
part of #783
This PR sets the foundations for dialects to implement query cancellation.
An
executable<O>interface is created and all relevant builders implement it.All
executeandstreamfunction accept an options object that might includesignal.This
signalis passed down to the executor, and handled there.The connection receives a hint at query time that it might need to prepare itself for cancelation - e.g. in PostgreSQL you need to make a request to get the
pidof the connection.The connection has a
cancelQuerymethod that, in dialects that support it, cancel the query on the database side.Verifying this works with PostgreSQL.