Skip to content

Conversation

@wallrj-cyberark
Copy link
Member

@wallrj-cyberark wallrj-cyberark commented Jan 6, 2026

Enable "ARK" tests in CI; those are tests which connect to real CyberArk Disco
APIs. This will reduce the risk of us releasing a broken the disco-agent chart.

Additionally, use a real UID in integration tests to satisfy real API validation
And add a cluster name, a shorter upload period, and a sample secret so that
it's easier to find the uploaded Secret in the UI.

Testing

The integration tests ran and succeeded, but with one failure due to a slow API response, so perhaps running these new tests for every PR commit, is going to cause frustration:

✖  internal/cyberark (1m1.162s) (coverage: 81.0% of statements)

=== Failed
=== FAIL: internal/cyberark TestCyberArkClient_PutSnapshot_RealAPI (61.09s)
    identity.go:293: I0123 10:47:28.571618] made successful request to StartAuthentication source="Identity.doStartAuthentication" summary="NewPackage"
    client_test.go:73: 
        	Error Trace:	/home/runner/work/jetstack-secure/jetstack-secure/internal/cyberark/client_test.go:73
        	Error:      	Received unexpected error:
        	            	failed to perform HTTP request to advance authentication: Post "https://anb5751.id.integration-cyberark.cloud/Security/AdvanceAuthentication": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
        	Test:       	TestCyberArkClient_PutSnapshot_RealAPI

DONE 277 tests, 1 failure in 62.750s
make: *** [make/test-unit.mk:5: test-unit] Error 1
Error: Process completed with exit code 2.

The E2E CI job ran and succeeded:

Here's a screenshot of the uploaded secrets

image

@wallrj-cyberark wallrj-cyberark force-pushed the ark-e2e-tests branch 2 times, most recently from 18449c8 to 0dc640b Compare January 7, 2026 15:17
@wallrj-cyberark wallrj-cyberark force-pushed the ark-e2e-tests branch 2 times, most recently from 09103a6 to cc7d379 Compare January 23, 2026 09:49
@wallrj-cyberark wallrj-cyberark changed the title WIP: Enable CyberArk integration tests in CI WIP: Enable CyberArk E2E and integration tests in CI Jan 23, 2026
Enable "ARK" tests in CI; those are tests which connect to real CyberArk Disco
APIs. This will reduce the risk of us releasing a broken the disco-agent chart.

Additionally, use a real UID in integration tests to satisfy real API validation
And add a cluster name, a shorter upload period, and a sample secret so that
it's easier to find the uploaded Secret in the UI.

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj-cyberark wallrj-cyberark changed the title WIP: Enable CyberArk E2E and integration tests in CI Enable CyberArk E2E and integration tests in CI Jan 23, 2026
Copy link
Member Author

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inteon inteon merged commit 459b0d1 into master Jan 23, 2026
7 of 8 checks passed
@wallrj-cyberark wallrj-cyberark deleted the ark-e2e-tests branch January 23, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants