Skip to content

Conversation

@jcsteh
Copy link
Owner

@jcsteh jcsteh commented Jul 28, 2025

Fixes #1294.

Note that this uses the last focused item. That means this won't be very useful in some cases if you have multiple items selected. It's unclear to me whether that is a desired use case or not, and if it is, how it should be handled.

…selected and Preferences -> Editing Behavior -> Tab through MIDI notes is enabled.
@github-actions
Copy link
Contributor

@jcsteh
Copy link
Owner Author

jcsteh commented Sep 10, 2025

@ScottChesworth, ping? Are you happy with this?

@ScottChesworth
Copy link
Collaborator

Sorry I forgot to write feedback. Testing it here, there are two things still needing some attention:

  1. Sometimes previews don't play. I haven't managed to pin down why they won't, it's typically somewhere around the 3rd to 5th tab in a direction they'll go silent, if I change direction for a few presses then revisit the notes that didn't play previews they usually work on the second pass. Not very helpful yet I know. Any ideas on how to troubleshoot appreciated.
  2. REAPER tabs through notes in selected items, not only last focused. Is that hard to implement?

@jcsteh
Copy link
Owner Author

jcsteh commented Sep 10, 2025

  1. Sometimes previews don't play.

Hmm. I was seeing that too, but I thought I fixed it. 😕

  1. REAPER tabs through notes in selected items, not only last focused. Is that hard to implement?

Yeah, it is pretty hard, unfortunately. This requires that we play notes in multiple takes, which means potentially multiple tracks. OSARA's MIDI preview code can't handle that. It could possibly be extended to do so, but that's not going to be easy.

I guess we should draft this one then until I/someone else has time to poke at it?

@ScottChesworth
Copy link
Collaborator

Is there a way to persuade REAPER it only cares about the notes in last focused item instead? Obviously it's not great to override their intended UX, but given how messy splitting MIDI items can be when this option isn't enabled, maybe this could be a special case until someone has time to work on the preview code. I can't think of a way to do that without overriding the selection the user made though, that feels way too heavy handed.

@jcsteh
Copy link
Owner Author

jcsteh commented Sep 10, 2025

Not without completely rewriting tab to transient, no.

@ScottChesworth ScottChesworth marked this pull request as draft September 10, 2025 13:41
@ScottChesworth
Copy link
Collaborator

Oki doke, I've drafted it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When Prefs/Editing Behavior/Tab through MIDI notes is checked and a take containing MIDI is selected, can OSARA play note previews?

3 participants