Skip to content

Conversation

@shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Jan 5, 2026

This PR adds biome.json to enforce consistent 2-space indentation and single quotes for JavaScript and CSS files. This aligns with project style guides, automates formatting via pre-commit hooks, and prevents manual style changes from being overwritten.

Currently, our Biome setup relies on default settings, which violates Google coding style guidelines. Specifically:

  • Quotation Marks: Biome's defaults do not enforce single quotes for JavaScript (as per js_style.txt: screen/8NaEr3SswN6qx6D) and CSS property values (as per css_style.txt: screen/9KCh8ZVQ4ByPeDR).
  • Indentation: Biome's defaults do not consistently enforce 2 spaces for indentation across HTML (screen/97ZZstQc4iH4Dsb) and JavaScript (screen/3crxm5peLvRE2kj) files.

This configuration explicitly sets these rules to ensure full compliance.

Benefits:

  • Consistent and readable JS/CSS code.
  • Automated style enforcement.
  • Reduced developer friction.

To Test:
Make a style-violating change in a .js or .css file and attempt to commit. Biome should automatically reformat it.

Fixes #<issue_number_goes_here> 🦕

@shuoweil shuoweil self-assigned this Jan 5, 2026
@shuoweil shuoweil requested review from a team as code owners January 5, 2026 21:47
@shuoweil shuoweil requested a review from jialuoo January 5, 2026 21:47
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 5, 2026
@shuoweil shuoweil requested a review from tswast January 5, 2026 21:47
@shuoweil shuoweil force-pushed the shuowei-configure-biome branch from 4e1f971 to 2bdf31a Compare January 5, 2026 21:56
@shuoweil shuoweil enabled auto-merge (squash) January 5, 2026 22:03
@shuoweil shuoweil merged commit 81e27b3 into main Jan 5, 2026
20 of 26 checks passed
@shuoweil shuoweil deleted the shuowei-configure-biome branch January 5, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants