-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix: correct typos in log messages and build base log #22682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tushar Jamdade <tushar@DESKTOP-0D1FVJR.localdomain>
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22682 +/- ##
===========================================
+ Coverage 45.36% 65.85% +20.49%
===========================================
Files 244 1073 +829
Lines 13333 116095 +102762
Branches 2719 2931 +212
===========================================
+ Hits 6049 76459 +70410
- Misses 6983 35399 +28416
- Partials 301 4237 +3936
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
|
||
| * Jul 15 2021 <danfengl@vmware.com> | ||
| - Create this file to trigger build base action in buld-package workflow | ||
| - Create this file to trigger build base action in build-package workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the type in the log as it was
Signed-off-by: Tushar Jamdade <tushar@DESKTOP-0D1FVJR.localdomain>
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Fixes typos at three locations in log messages and the .buildbaselog file.
This is a non-functional change that improves clarity and consistency without affecting behavior.
Issue being fixed
Fixes #22672
Please indicate you've done the following: