Skip to content

Conversation

@Tusharjamdade
Copy link

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Fixes typos at three locations in log messages and the .buildbaselog file.
This is a non-functional change that improves clarity and consistency without affecting behavior.

Issue being fixed

Fixes #22672

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Tushar Jamdade <tushar@DESKTOP-0D1FVJR.localdomain>
@Tusharjamdade Tusharjamdade requested a review from a team as a code owner December 25, 2025 10:38
@Tusharjamdade Tusharjamdade changed the title release-note/update fix: correct typos in log messages and build base log Dec 25, 2025
Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.85%. Comparing base (c8c11b4) to head (04e7701).
⚠️ Report is 611 commits behind head on main.

Files with missing lines Patch % Lines
src/core/main.go 0.00% 1 Missing ⚠️
src/pkg/project/models/project.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22682       +/-   ##
===========================================
+ Coverage   45.36%   65.85%   +20.49%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76459    +70410     
- Misses       6983    35399    +28416     
- Partials      301     4237     +3936     
Flag Coverage Δ
unittests 65.85% <0.00%> (+20.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/main.go 0.00% <0.00%> (ø)
src/pkg/project/models/project.go 37.25% <0.00%> (ø)

... and 985 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


* Jul 15 2021 <danfengl@vmware.com>
- Create this file to trigger build base action in buld-package workflow
- Create this file to trigger build base action in build-package workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the type in the log as it was

Signed-off-by: Tushar Jamdade <tushar@DESKTOP-0D1FVJR.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix typos in log messages and buildbaselog

6 participants