Rubocop 8.9 #73
Merged
Rubocop 8.9 #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version requirement on, - rubocop - rubocop-performance - rubocop-rails
composerinteralia
approved these changes
Aug 7, 2020
koic
added a commit
to koic/rubocop-github
that referenced
this pull request
Apr 29, 2021
Follow github#73. `Lint/BinaryOperatorWithIdenticalOperands` cop has introduced by RuboCop 0.89.0 and RuboCop GitHub uses the cop. rubocop/rubocop@d94c4a4 This PR prevents the following error when using RuboCop 0.88 or lower. ```console % bundle exec rake (snip) Running RuboCop... Error: unrecognized cop Lint/BinaryOperatorWithIdenticalOperands found in config/_default_shared.yml RuboCop failed! ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended up needing a few more changes not in #72 to get fully up to date with rubocop.