Skip to content

Fix deprecated Naming/PredicateName cop - rename to Naming/PredicatePrefix #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peter-evans merged 4 commits into from
Jun 9, 2025
Merged

Fix deprecated Naming/PredicateName cop - rename to Naming/PredicatePrefix #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d3364e
Initial plan for issue
Copilot Jun 5, 2025
091438d
Initial analysis and plan for fixing deprecated Naming/PredicateName cop
Copilot Jun 5, 2025
f427905
Fix deprecated Naming/PredicateName cop - rename to Naming/PredicateP…
Copilot Jun 5, 2025
9ba2d39
Remove vendor folder from repository
Copilot Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ test/tmp
test/version_tmp
tmp
bin/
vendor/

# YARD artifacts
.yardoc
Expand Down
8 changes: 4 additions & 4 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: .
specs:
rubocop-github (0.25.0)
rubocop (>= 1.72)
rubocop (>= 1.76)
rubocop-performance (>= 1.24)
rubocop-rails (>= 2.23)

Expand Down Expand Up @@ -74,18 +74,18 @@ GEM
rainbow (3.1.1)
rake (13.2.1)
regexp_parser (2.10.0)
rubocop (1.75.7)
rubocop (1.76.0)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.44.0, < 2.0)
rubocop-ast (>= 1.45.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.44.1)
rubocop-ast (1.45.0)
parser (>= 3.3.7.2)
prism (~> 1.4)
rubocop-performance (1.25.0)
Expand Down
2 changes: 1 addition & 1 deletion config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ Naming/MethodName:
Naming/MethodParameterName:
Enabled: false

Naming/PredicateName:
Naming/PredicatePrefix:
Enabled: false

Naming/RescuedExceptionsVariableName:
Expand Down
2 changes: 1 addition & 1 deletion rubocop-github.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |s|

s.required_ruby_version = ">= 3.1.0"

s.add_dependency "rubocop", ">= 1.72"
s.add_dependency "rubocop", ">= 1.76"
s.add_dependency "rubocop-performance", ">= 1.24"
s.add_dependency "rubocop-rails", ">= 2.23"

Expand Down