Fix for #191 slf4j simple-logger for logging #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSnoozer
changed the title
TheSnoozer
changed the title
Collaborator
|
Hah nice, you beat me to it :-) Looks good! |
ktoso
added a commit
that referenced
this pull request
May 21, 2015
Fix for #191 slf4j simple-logger for logging
Collaborator
Author
|
@ktoso , Thanks for pulling this in! |
Collaborator
|
Far too little 😉 Will retry releasing today (Seems like encoding problems, weird - I'm on a mac) |
Contributor
|
hi @ktoso, hope everything is fine :) The slf4j problem is correct I see but in the future 2.1.15 release is that right? Cheers. |
Collaborator
|
Yes, I'll roll an update that fixes this problem soon. |
Collaborator
|
More details here #198 |
Contributor
|
Okay Konrad, Thank you! ;) Great work for that cool plugin by the way... 2015-06-03 14:55 GMT+02:00 Konrad Malawski notifications@github.com:
Marc Cappelletti |
Collaborator
|
Glad you find it useful, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just created the PR.
Its way too late to actually pull this right in the repo...:-)
I also override some simple-logger's default properties to look like the normal maven log outpout. However those can still be overriden by setting -Dorg.slf4j.simpleLogger.showThreadName=true.
Link to issue: #191