-
Notifications
You must be signed in to change notification settings - Fork 634
chore: Update XFails Report #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Auto-generated xfails report based on current test suite markers.
Summary of ChangesHello @flashinfer-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automatically updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughA new static report file is added at Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-12-30T09:34:39.900ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the automated xfails report. The report is well-structured, but I've identified one expected failure that uses a non-descriptive reason, str(e). This originates from the test file tests/gemm/test_mm_fp4.py where pytest.xfail is called with a dynamic value. Using a descriptive string literal instead would improve the clarity and utility of this report. My specific comment provides more detail on this.
| [1 xfails] str(e) | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/gemm/test_mm_fp4.py:92 | ||
| Test: _test_mm_fp4 | ||
| Type: runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xfail reason str(e) is not descriptive and makes the report less useful. This is caused by the use of pytest.xfail(str(e)) in tests/gemm/test_mm_fp4.py on line 92. The static analysis script that generates this report cannot resolve the value of str(e) and therefore uses the literal code as the reason.
To improve this, the pytest.xfail call should be updated to use a descriptive string literal. Based on the context in the test file, a more informative reason would be something like:
"cuDNN backend for FP4 GEMM with mxfp4 on SM120+ requires cuDNN 9.14.0+"This change would make the xfail report more understandable and aid in tracking test failures.
Summary
This PR updates the xfails report based on the current test suite.
Changes
reports/xfails_report.txtwith current xfail markers from the test suiteHow to Review
reports/xfails_report.txtNotes
pytest.mark.xfailmarkers in the test suite🤖 This PR was automatically generated by the update-xfails-report workflow
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.