Fix implicit-any error for bare tuple and Callable (#1970) #1973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1970
When the
implicit-anyerror is enabled, baretupleandCallableannotations now generate errors, matching the existing behavior forlist.Before
After
Changes
ImplicitAnyerror forSpecialForm::Tuple,SpecialForm::Callable, andSpecialForm::Typeincanonicalize_all_class_typesImplicitAnyerror forClassDef(tuple)to handle the builtintupleNotes
typestill doesn't error because it's not defined as generic in typeshed (thetypeclass has no type parameters). However,typing.Typedoes error correctly.