[mob][locker] Add multiselect support for files and collections #8570
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…roll logic - Add _getOwnedFiles helper to filter shared files with toast notification - Apply ownership checks to download, delete, add-to, and mark important actions - Remove scrollController passing from RecentsSectionWidget (not needed) - Simplify ItemListView bottom padding logic to static when selection enabled - Reduce overlay padding from 270 to 200 Co-Authored-By: Claude <noreply@anthropic.com>
…on fixes Enable multiselect for collections on AllCollectionsPage with proper ownership filtering that shows a toast when shared collections are skipped. Fix check mark animation to replace 3-dots menu instead of avatars. Add canEdit/canShare protection for Important collection. Simplify overlay by removing scroll collapse behavior. Co-Authored-By: Claude <noreply@anthropic.com>
AmanRajSinghMourya
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| FileSelectionOverlayBar( | ||
| selectedFiles: _selectedFiles, | ||
| files: _recentFiles, | ||
| scrollController: _scrollController, |
There was a problem hiding this comment.
HomePage now passes files: _recentFiles into FileSelectionOverlayBar, but the recents list is rendered from _displayedFiles in RecentsSectionWidget (filtered when chips are active). Because select‑all in FileSelectionOverlayBar uses widget.files to compute the count and to selectAll (file_selection_overlay_bar.dart:186‑202), pressing Select All after filtering will silently select hidden files and apply bulk actions to them. Consider wiring the filtered list into the overlay so Select All matches what the user can see.
Useful? React with 👍 / 👎.
Use ValueNotifier to share displayed files from RecentsSectionWidget to FileSelectionOverlayBar, so Select All only selects filtered files. Also fix Deselect All button state to check if actual displayed files are selected, not just count comparison. Co-Authored-By: Claude <noreply@anthropic.com>
The early return path in _updateFilteredFiles() was not calling _updateDisplayedFilesNotifier(), causing stale displayed files in FileSelectionOverlayBar after clearing collection filters. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
I think the option should be added |
…stency - Add leave button in collection multiselect for shared incoming collections - Show share/edit only for owned collections, leave only for shared - Update leaveMultipleCollection to use showAlertBottomSheet with GradientButton - Refactor delete confirmation sheet to match alert bottom sheet style - Wrap collection action buttons in container for continuous look Co-Authored-By: Claude <noreply@anthropic.com>
…hecks Co-Authored-By: Claude <noreply@anthropic.com>
Summary