Fix asan.test_asyncify_longjmp #20740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test started failing after the compiler-rt upgrade because we started depending on the `getrlimit` syscall, and this test builds in `-sSTRICT` mode which disables `ALLOW_UNIMPLEMENTED_SYSCALLS` which means stub syscalls are not included.
Collaborator
Author
|
Will land TBR once that tests pass to green the waterfall. |
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Jan 6, 2026
`StackSizeIsUnlimited` in `lib/sanitizer_common/sanitizer_posix_libcdep.cpp` was excluded from Emscripten build along with several other methodsin emscripten-core#20740, presumably because they call `setrlimit` and `getrlimit`. A new call to `StackSizeIsUnlimited` was added in `lib/asan/asan_rtl.cpp` in this version, so this excludes the call too.
aheejin
added a commit
that referenced
this pull request
Jan 10, 2026
This updates compiler-rt from 20.1.8 to LLVM 21.1.8: https://github.com/llvm/llvm-project/releases/tag/llvmorg-21.1.8 Additional change: - `StackSizeIsUnlimited` in `lib/sanitizer_common/sanitizer_posix_libcdep.cpp` was excluded from Emscripten build along with several other methods in #20740. A new call to `StackSizeIsUnlimited` was added in `lib/asan/asan_rtl.cpp` in this version, so this excludes the call too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing after the compiler-rt upgrade because we started depending on the
getrlimitsyscall, and this test builds in-sSTRICTmode which disablesALLOW_UNIMPLEMENTED_SYSCALLSwhich means stub syscalls are not included.