Skip to content

Conversation

@NullVoxPopuli
Copy link
Contributor

  • copy tests from ember-element-helper
  • implement the element keyword in strict mode (safest, existing using is shadowed)

Need to take a quick detour to add gjs/gts testing in this repo

@NullVoxPopuli NullVoxPopuli changed the title Implement {{element 'xyz'}} Implement (element 'xyz') Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Estimated Asset Sizes

Diff

Details

This PRmain
╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 352.11 KB │ 203.55 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤══════════╗
║ @ember/*             │ Min       │ Gzip     ║
╟──────────────────────┼───────────┼──────────╢
║ Total                │ 313.81 KB │ 181.8 KB ║
╟──────────────────────┼───────────┼──────────╢
║ -internals           │ 36.61 KB  │ 26 KB    ║
║ application          │ 13.24 KB  │ 8.03 KB  ║
║ array                │ 13.05 KB  │ 7.54 KB  ║
║ canary-features      │ 304 B     │ 419 B    ║
║ component            │ 2.05 KB   │ 1.57 KB  ║
║ controller           │ 1.96 KB   │ 1.45 KB  ║
║ debug                │ 11.73 KB  │ 8.14 KB  ║
║ deprecated-features  │ 31 B      │ 77 B     ║
║ destroyable          │ 561 B     │ 383 B    ║
║ enumerable           │ 259 B     │ 387 B    ║
║ helper               │ 1.08 KB   │ 830 B    ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB  ║
║ modifier             │ 1.22 KB   │ 987 B    ║
║ object               │ 35.98 KB  │ 22.1 KB  ║
║ owner                │ 159 B     │ 178 B    ║
║ renderer             │ 630 B     │ 491 B    ║
║ routing              │ 59.37 KB  │ 33.91 KB ║
║ runloop              │ 2.36 KB   │ 1.5 KB   ║
║ service              │ 1 KB      │ 858 B    ║
║ template             │ 654 B     │ 538 B    ║
║ template-compilation │ 429 B     │ 366 B    ║
║ template-compiler    │ 123.33 KB │ 59.68 KB ║
║ template-factory     │ 370 B     │ 351 B    ║
║ test                 │ 923 B     │ 627 B    ║
║ utils                │ 4.11 KB   │ 3.63 KB  ║
║ version              │ 55 B      │ 131 B    ║
╚══════════════════════╧═══════════╧══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.29 KB │ 21.76 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.78 KB  │ 1.38 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 627 B    ║
║ node            │ 175 B    │ 249 B    ║
║ opcode-compiler │ 1.11 KB  │ 905 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 333 B    ║
║ reference       │ 548 B    │ 544 B    ║
║ runtime         │ 10.32 KB │ 5.22 KB  ║
║ tracking        │ 1.34 KB  │ 1.18 KB  ║
║ util            │ 1.85 KB  │ 1.59 KB  ║
║ validator       │ 15.53 KB │ 6.9 KB   ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝
╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 352.11 KB │ 203.55 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤══════════╗
║ @ember/*             │ Min       │ Gzip     ║
╟──────────────────────┼───────────┼──────────╢
║ Total                │ 313.81 KB │ 181.8 KB ║
╟──────────────────────┼───────────┼──────────╢
║ -internals           │ 36.61 KB  │ 26 KB    ║
║ application          │ 13.24 KB  │ 8.03 KB  ║
║ array                │ 13.05 KB  │ 7.54 KB  ║
║ canary-features      │ 304 B     │ 419 B    ║
║ component            │ 2.05 KB   │ 1.57 KB  ║
║ controller           │ 1.96 KB   │ 1.45 KB  ║
║ debug                │ 11.73 KB  │ 8.14 KB  ║
║ deprecated-features  │ 31 B      │ 77 B     ║
║ destroyable          │ 561 B     │ 383 B    ║
║ enumerable           │ 259 B     │ 387 B    ║
║ helper               │ 1.08 KB   │ 830 B    ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB  ║
║ modifier             │ 1.22 KB   │ 987 B    ║
║ object               │ 35.98 KB  │ 22.1 KB  ║
║ owner                │ 159 B     │ 178 B    ║
║ renderer             │ 630 B     │ 491 B    ║
║ routing              │ 59.37 KB  │ 33.91 KB ║
║ runloop              │ 2.36 KB   │ 1.5 KB   ║
║ service              │ 1 KB      │ 858 B    ║
║ template             │ 654 B     │ 538 B    ║
║ template-compilation │ 429 B     │ 366 B    ║
║ template-compiler    │ 123.33 KB │ 59.68 KB ║
║ template-factory     │ 370 B     │ 351 B    ║
║ test                 │ 923 B     │ 627 B    ║
║ utils                │ 4.11 KB   │ 3.63 KB  ║
║ version              │ 55 B      │ 131 B    ║
╚══════════════════════╧═══════════╧══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.29 KB │ 21.76 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.78 KB  │ 1.38 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 627 B    ║
║ node            │ 175 B    │ 249 B    ║
║ opcode-compiler │ 1.11 KB  │ 905 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 333 B    ║
║ reference       │ 548 B    │ 544 B    ║
║ runtime         │ 10.32 KB │ 5.22 KB  ║
║ tracking        │ 1.34 KB  │ 1.18 KB  ║
║ util            │ 1.85 KB  │ 1.59 KB  ║
║ validator       │ 15.53 KB │ 6.9 KB   ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants