ErrorTracker.report() doesn't accept manual creations

[KristerV]

hey. i like this library so much i'm depending on it now :)

I want Logger.error() to send errors to the UI. So I created my own LoggerBackend. I've tried creating RuntimeExceptions, actual stacktraces, empty values, strings, everything i can think of, but ErrorTracker.report() always ends with

** (MatchError) no match of right hand side value: [:id, :kind, :reason, :source_line, :source_function, :status, :fingerprint, :last_occurrence_at, :inserted_at, :updated_at]
    (ecto 3.12.5) lib/ecto/repo/schema.ex:365: Ecto.Repo.Schema.do_insert/4
    (ecto 3.12.5) lib/ecto/repo/schema.ex:311: Ecto.Repo.Schema.insert!/4
    (viru 0.1.0) lib/viru/repo.ex:19: Viru.Repo.insert!/2
    (error_tracker 0.5.1) lib/error_tracker.ex:309: anonymous fn/5 in ErrorTracker.upsert_error!/5
    (ecto_sql 3.12.1) lib/ecto/adapters/sql.ex:1400: anonymous fn/3 in Ecto.Adapters.SQL.checkout_or_transaction/4
    (db_connection 2.7.0) lib/db_connection.ex:1756: DBConnection.run_transaction/4
    (error_tracker 0.5.1) lib/error_tracker.ex:307: ErrorTracker.upsert_error!/5
    (error_tracker 0.5.1) lib/error_tracker.ex:145: ErrorTracker.report/3
    (tower_error_tracker 0.3.5) lib/tower_error_tracker/reporter.ex:32: TowerErrorTracker.Reporter.report_event/1
    (tower 0.8.0) lib/tower.ex:478: Tower.report_event/2
    (elixir 1.17.2) lib/enum.ex:987: Enum."-each/2-lists^foreach/1-0-"/2
    (kernel 10.0.1) logger_backend.erl:52: :logger_backend.call_handlers/3
    (viru 0.1.0) lib/viru/etl_worker.ex:59: Viru.ETLWorker.run_etl_with_catch/1
    (viru 0.1.0) lib/viru/etl_worker.ex:44: Viru.ETLWorker.handle_info/2
    (stdlib 6.0.1) gen_server.erl:2173: :gen_server.try_handle_info/3
    (stdlib 6.0.1) gen_server.erl:2261: :gen_server.handle_msg/6
    (stdlib 6.0.1) proc_lib.erl:329: :proc_lib.init_p_do_apply/3

I'm discussing with the creator of Tower about this too, since they have a logger handler built in, they just can't report messages to ErrorTracker: mimiquate/tower_error_tracker#43

it would be super nice if the report() function could just accept a message, maybe level, maybe metadata, but no exception and no stacktrace.

[crbelaus]

Thanks for reaching out!

A logger handler is definitely on the radar. As you say, this would require accepting a message and some extra metadata without requiring an explicit exception or stacktrace.

[grzuy]

** (MatchError) no match of right hand side value: [:id, :kind, :reason, :source_line, :source_function, :status, :fingerprint, :last_occurrence_at, :inserted_at, :updated_at]
(ecto 3.12.5) lib/ecto/repo/schema.ex:365: Ecto.Repo.Schema.do_insert/4

@KristerV Not sure this exception you're seeing is related in any way to error_tracker...

The above line in your stacktrace appears to be related to this particular change in ecto https://github.com/elixir-ecto/ecto/pull/4525/files#diff-91ed3e8c550063fcf5e2df36020d92405a303c5f5745c0bf643c7dc4c538befbR365 from last October which was first included in the last ecto version 3.12.5.

Ecto.Schema.__schema__(:insertable_fields) started returning a tuple instead of a list. But it seems from your stacktrace that, despite using 3.12.5, your call to Ecto.Schema.__schema__(:insertable_fields) is still returning a list instead of a tuple?

Do you have anything special in your application, your ecto repo, or any other dependencies related to ecto that would explain something like this?

[KristerV]

totally possible. the only thing that's special that i can think of is that i'm using Ash and AshPostgres. buuut i mean it's still just using Ecto so not sure if that helps.

Here are all my deps

  {:phoenix, "~> 1.7.14"},
  {:phoenix_ecto, "~> 4.5"},
  {:ecto_sql, "~> 3.10"},
  {:postgrex, ">= 0.0.0"},
  {:phoenix_html, "~> 4.1"},
  {:phoenix_live_reload, "~> 1.2", only: :dev},
  {:phoenix_live_view, "~> 1.0.0-rc.1", override: true},
  {:floki, ">= 0.30.0", only: :test},
  {:phoenix_live_dashboard, "~> 0.8.3"},
  {:esbuild, "~> 0.8", runtime: Mix.env() == :dev},
  {:tailwind, "~> 0.2", runtime: Mix.env() == :dev},
  {:heroicons,
   github: "tailwindlabs/heroicons",
   tag: "v2.1.1",
   sparse: "optimized",
   app: false,
   compile: false,
   depth: 1},
  {:swoosh, "~> 1.5"},
  {:finch, "~> 0.13"},
  {:telemetry_metrics, "~> 1.0"},
  {:telemetry_poller, "~> 1.0"},
  {:gettext, "~> 0.20"},
  {:jason, "~> 1.2"},
  {:dns_cluster, "~> 0.1.1"},
  {:bandit, "~> 1.5"},
  {:req, "~> 0.5.0"},
  {:shorter_maps, github: "Galagora/shorter_maps"},
  {:mox, "~> 1.0", only: :test},
  {:timex, "~> 3.0"},
  {:ash, "~> 3.4.34"},
  {:picosat_elixir, "~> 0.2"},
  {:ash_postgres, "~> 2.0.0"},
  {:ex_doc, "~> 0.29", only: :dev, runtime: false},
  {:multipart, "~> 0.4.0"},
  {:ssl_verify_fun, "~> 1.1.7"},
  {:ex_azure_storage, github: "KristerV/ex_azure_storage"},
  {:nimble_options, "~> 1.1.1", override: true},
  {:csv, "~> 3.2"},
  # {:tower, "~> 0.8.0"},
  # {:tower_error_tracker, "~> 0.3.5"}
  {:tower_error_tracker, github: "mimiquate/tower_error_tracker", branch: "logger-messages-2"}

However what seems interesting to me is that Ecto.Schema.__schema__(:insertable_fields) doesn't exist in any documentation..

so is that a legit function to use?

[KristerV]

ahhhaa! I got it working. i saw that in master :insertable_fields is handled differently than in 3.12.5. so i added {:ecto, github: "elixir-ecto/ecto", override: true} and now everything finally works!

that was a pro catch btw @grzuy .

i should stop using bleeding edge versions :(

[grzuy]

However what seems interesting to me is that Ecto.Schema.__schema__(:insertable_fields) doesn't exist in any documentation..

Right, it's a non public Ecto function.
You're "calling it" indirectly via like Repo.insert, not directly in your app source code.

[KristerV]

crap. now Ash broke. something about EXLUDED not being a schema. wow. i wonder what the real solution here is. like why does error_tracker specifically break with 3.12.5? i'm going to try downgrading.

[KristerV]

yeah, {:ecto, "3.12.4", override: true} works. so i guess i'll lock the version in for now and come back later, when ecto gets an official update.