-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: add classification filters for picture description #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add classification filters for picture description #2836
Conversation
|
❌ DCO Check Failed Hi @drukpa1455, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for drk <drukpa1455@gmail.com>
I, drk <drukpa1455@gmail.com>, hereby add my Signed-off-by to this commit: 250eaca4e4e5db39e09aa4e92295b33f83f189c4
I, drk <drukpa1455@gmail.com>, hereby add my Signed-off-by to this commit: 21795c67ddc80d77b9c8ed6085afa10843ee3f11"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
|
Related Documentation 1 document(s) may need updating based on files changed in this PR: Docling |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, drk <drukpa1455@gmail.com>, hereby add my Signed-off-by to this commit: 250eaca Signed-off-by: drk <drukpa1455@gmail.com>
| if not allow and not deny: | ||
| return True | ||
| predicted = None | ||
| for annotation in annotations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotations are deprecated, please use the new meta container.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
thanks for the review. this project has been a big help. pr updates: use the new meta container (description + classification), type allow/deny with pictureclassificationlabel, and add targeted tests for the filter behavior plus the classifier test update. |
…iption-classification-filters Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
|
we recently merged the changes which makes the new meta annotation format usable. Since this created some conflicts with your PR, we took care of resolving those conflicts. @drukpa1455 for concluding this PR we only need you to sign-off your commits, the rest looks good. |
Summary