Skip to content

Conversation

@drukpa1455
Copy link

@drukpa1455 drukpa1455 commented Jan 4, 2026

Summary

  • add classification allow/deny/min confidence options for picture descriptions
  • skip descriptions when picture classifications do not pass filters

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

DCO Check Failed

Hi @drukpa1455, your pull request has failed the Developer Certificate of Origin (DCO) check.

This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format.


🛠 Quick Fix: Add a remediation commit

Run this command:

git commit --allow-empty -s -m "DCO Remediation Commit for drk <drukpa1455@gmail.com>

I, drk <drukpa1455@gmail.com>, hereby add my Signed-off-by to this commit: 250eaca4e4e5db39e09aa4e92295b33f83f189c4
I, drk <drukpa1455@gmail.com>, hereby add my Signed-off-by to this commit: 21795c67ddc80d77b9c8ed6085afa10843ee3f11"
git push

🔧 Advanced: Sign off each commit directly

For the latest commit:

git commit --amend --signoff
git push --force-with-lease

For multiple commits:

git rebase --signoff origin/main
git push --force-with-lease

More info: DCO check report

@dosubot
Copy link

dosubot bot commented Jan 4, 2026

Related Documentation

1 document(s) may need updating based on files changed in this PR:

Docling

How did I do? Any feedback?  Join Discord

@mergify
Copy link

mergify bot commented Jan 4, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

I, drk <drukpa1455@gmail.com>, hereby add my Signed-off-by to this commit: 250eaca

Signed-off-by: drk <drukpa1455@gmail.com>
@drukpa1455 drukpa1455 changed the title Add classification filters for picture description feat: add classification filters for picture description Jan 4, 2026
if not allow and not deny:
return True
predicted = None
for annotation in annotations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations are deprecated, please use the new meta container.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling/models/picture_description_base_model.py 87.50% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@drukpa1455
Copy link
Author

thanks for the review. this project has been a big help.

pr updates: use the new meta container (description + classification), type allow/deny with pictureclassificationlabel, and add targeted tests for the filter behavior plus the classifier test update.

…iption-classification-filters

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
Copy link
Member

we recently merged the changes which makes the new meta annotation format usable. Since this created some conflicts with your PR, we took care of resolving those conflicts.

@drukpa1455 for concluding this PR we only need you to sign-off your commits, the rest looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants