Code cleanup and few bug fixes. #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BKSSMVenkateswarlu
commented
Feb 12, 2021
BKSSMVenkateswarlu
commented
- Code clean up & Indentation.
- Bug fixes.
Merging from Venkat's master
adding unsigned compare to KMInteger to remove the dependency
Remove public operations
Move unsigned compare
Revert "Move unsigned compare"
unsignedCompare & errorCode cleanup
Remove public operations
Code formatting
reason. 2. Incase of NOPAD sign if signature length is less than 256 add zero to the front and make length equal to 256.
subrahmanyaman
referenced
this pull request
in subrahmanyaman/JavaCardKeymaster
Aug 26, 2021
Code cleanup and few bug fixes.
mdwivedi
pushed a commit
that referenced
this pull request
Jan 14, 2022
Trusted confirmation changes for Jcard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.