Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Oct 23, 2023

This PR includes:

⚠️ Note:
Next to the listed changes quite some adoptions went into test flakeyness

  • adding a new third party package for the progress bar visualisation multi-progress-bar
  • a new helper in helper called getProgressBar
  • updates to the executePlugins function in core
  • styling helper to abstract color's and style into states
  • condition to show progress-bar depending on CLI arg

As the tests where really flakey I reused more of the same config files and added timestamps to the plugin outputs. This did dot fully sole the issue.

Example string:
Run Plugins: ████████████████████████████ 70% | Executing: Async Plugin 7
Run Plugins: ███████████████████████████████████████▉ 100% | Done running plugins

You can demo the progress bar by running:
nx execute cli collect --config=./packages/cli/test/plugin-progress-bar.config.mock.ts

cli-progress-bar.mov

closes #116

@BioPhoton BioPhoton self-assigned this Oct 25, 2023
@BioPhoton BioPhoton requested a review from matejchalk October 25, 2023 22:13
@BioPhoton BioPhoton added this to the 1. Internal MVP milestone Oct 25, 2023
@BioPhoton BioPhoton requested a review from matejchalk October 28, 2023 20:47
@BioPhoton BioPhoton mentioned this pull request Oct 28, 2023
2 tasks
BioPhoton and others added 3 commits October 29, 2023 11:00
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton mentioned this pull request Oct 29, 2023
@BioPhoton BioPhoton mentioned this pull request Oct 29, 2023
BioPhoton and others added 2 commits October 29, 2023 18:12
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
Copy link
Collaborator Author

#139 (comment) will get fixed in #180

@BioPhoton BioPhoton requested a review from matejchalk October 29, 2023 17:17
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what folder should I run the progress bar to get the example you mentioned working? When I run it from the root folder, I get the wrong score.
image

@BioPhoton BioPhoton merged commit 7d11d81 into main Oct 30, 2023
@BioPhoton BioPhoton deleted the add-progress-bar branch October 30, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add progress logging to CLI

5 participants