-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(utils): add progress visualisation logic #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejchalk
requested changes
Oct 29, 2023
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Closed
matejchalk
requested changes
Oct 29, 2023
Tlacenka
reviewed
Oct 29, 2023
Closed
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Collaborator
Author
|
#139 (comment) will get fixed in #180 |
matejchalk
approved these changes
Oct 30, 2023
Tlacenka
reviewed
Oct 30, 2023
Collaborator
Tlacenka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR includes:
multi-progress-barhelpercalledgetProgressBarexecutePluginsfunction incoreAs the tests where really flakey I reused more of the same config files and added timestamps to the plugin outputs. This did dot fully sole the issue.
Example string:
Run Plugins: ████████████████████████████ 70% | Executing: Async Plugin 7Run Plugins: ███████████████████████████████████████▉ 100% | Done running pluginsYou can demo the progress bar by running:
nx execute cli collect --config=./packages/cli/test/plugin-progress-bar.config.mock.tscli-progress-bar.mov
closes #116