-
Notifications
You must be signed in to change notification settings - Fork 15
feat(utils): performance TS ext #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit c45d91f
☁️ Nx Cloud last updated this comment at |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 2e3c518 with previous commit 0280600. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 3 audits improved, 👎 3 audits regressed, 15 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
658 other audits are unchanged. |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 2e3c518 with previous commit 0280600. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 94 | 🟢 94 | |
| Documentation | 🔴 36 | 🔴 36 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 | |
| JSDocs coverage | Documentation coverage | 🔴 36 | 🔴 36 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 93.9 % | 🟩 91 % | |
| JSDocs coverage | Types coverage | 🟥 64 undocumented types | 🟥 64 undocumented types | |
| Code coverage | Branch coverage | 🟩 91.6 % | 🟩 91.6 % |
441 other audits are unchanged.
13 other projects are unchanged.
# Conflicts: # packages/utils/src/lib/performance-observer.ts
Related to #1197
This PR includes:
perf-hooks.d.tstypes to extend performance APIs with Chrome DevTools Extensibility API types so we get autocomplete and type checks when using e.g.performance.mark('mark-name', { details: /*this is typed*/})