Skip to content

Update pyproject.toml #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haochengxia merged 1 commit into from
Aug 3, 2025
Merged

Update pyproject.toml #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ build = ["cp39-*", "cp310-*", "cp311-*", "cp312-*", "cp313-*"]
skip = ["*-win32", "*-manylinux_i686", "*-musllinux*", "pp*"]

# Set the environment variable for the wheel build step.
environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "15.0" }
environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "14.0" }
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change correctly aligns the two macOS deployment target settings, which is a good improvement. To further improve maintainability, you could consider removing the CMAKE_OSX_DEPLOYMENT_TARGET definition from [tool.scikit-build] (line 52) and rely on this environment variable as the single source of truth, as scikit-build-core will automatically use it. This would prevent the two values from becoming out of sync in the future.

A potential trade-off is that local builds (not using cibuildwheel) would then depend on the developer's environment or the Python interpreter's default deployment target, rather than being explicitly pinned in pyproject.toml.


# Test that the wheel can be imported
test-command = "python -c 'import libcachesim; print(\"Import successful\")'"
Expand Down