Polyfill ToWasmtimeResult and add eventually-necessary call sites
#12308
Conversation
This commit polyfills `wasmtime_internal_error::ToWasmtimeResult` in `wasmtime_environ`, adds the cargo feature plumbing that will eventually connect to the `"wasmtime_internal_error/anyhow"` cargo feature but for now just configures this polyfill, and adds uses of the polyfill at all the sites that will be necessary once we swap out `anyhow` for `wasmtime_internal_error`. Currently, the polyfill is just an identity function, because `wasmtime::Result`/`wasmtime_environ::error::Result` is just another name for `anyhow::Result`. Once we do move away from `anyhow`, however, that will no longer be the case, and these uses will do the necessary conversion. My goal with landing this as an incremental commit is to make it so that the actual commit that does the error crate swap out can be as close to _just_ the `Cargo.toml` dependency change, without any other code changes as much as possible. This, in turn, means that swap out should be super easy to revert, if necessary.
|
Personally I'd like to see this trait used as an absolute last resort "quick hack before we figure out what's best to do instead" ideally. What would you think about, instead of using this trait internally, instead propagating the usage of Additionally, looking forward a bit, one thing I'm worried about is |
alexcrichton
requested review from
alexcrichton
and removed request for
a team and
pchickey
github-actions
bot
added
wasmtime:api
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "wasmtime:api", "wizer"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
2 participants
This commit polyfills
wasmtime_internal_error::ToWasmtimeResultinwasmtime_environ, adds the cargo feature plumbing that will eventually connect to the"wasmtime_internal_error/anyhow"cargo feature but for now just configures this polyfill, and adds uses of the polyfill at all the sites that will be necessary once we swap outanyhowforwasmtime_internal_error. Currently, the polyfill is just an identity function, becausewasmtime::Result/wasmtime_environ::error::Resultis just another name foranyhow::Result. Once we do move away fromanyhow, however, that will no longer be the case, and these uses will do the necessary conversion.My goal with landing this as an incremental commit is to make it so that the actual commit that does the error crate swap out can be as close to just the
Cargo.tomldependency change, without any other code changes as much as possible. This, in turn, means that swap out should be super easy to revert, if necessary.