Prototype how console output in general and for QUnit specifically could be improved #35
Conversation
| QUnit.done = function(results){ | ||
| results.tracebacks = striderErrors; | ||
| QUnit.done(function(results) { | ||
| results.tracebacks = failures; | ||
| results.url = window.location.pathname; | ||
| BrowserStack.post("/_report", results, function(){}); |
There was a problem hiding this comment.
This is the first step of outputting failed assertions on the console. Before, nothing was logged, since striderErrors was always reset to an empty array, while the _progress event didn't log anything at all.
There was a problem hiding this comment.
we did figure it out eventually and fixed it few days back.
finally, got merge into master today only, hence conflicting with your version :(
|
If you've followed the changes and my comments above, continue here: My changes here break the runner of anything that isn't QUnit. Addressing that requires a lot more work and testing with each supported framework. Since there are no unit tests, testing each changes requires a rather slow run of |
|
yes, we have been discussing this internally. Today only, we realized JSON.parse() doesn't handle newline characters (when trying to make it run with jQuery), and we have no idea how much it will break others. We will start working on it more aggressively. |
|
also, i will try to get this merged. we did some similar changes here: https://github.com/browserstack/browserstack-runner/pull/34/files |
|
Wow, that's pretty unfortunate timing. I had no idea you were working on this, but then you had no idea that I was working on it either. I'm going to close this and test the updated version and maybe redo some changes if they're still useful. |
|
oops. i was just merging them :P |
|
yes, would love to get chalk support - very much like how its in your pull request. |
2 participants
This is a prototype that is not meant to be merged, I just wanted to share the result on my experiment. I will add some inline comments to explain how this might be useful to resolve #29.