[Bug] Fix remoting server netty server codec thread reuse problem #9992
Description
Before Creating the Bug Report
-
I found a bug, not just asking a question, which should be created in GitHub Discussions.
-
I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
-
I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
Runtime platform environment
OS: Cross-platform (Issue found via static code analysis)
RocketMQ version
Branch: develop
JDK Version
JDK 1.8
Describe the Bug
When creating NettyRemotingServer, if the serverNettyWorkerGroupEnable parameter is set to false, Netty’s codec and handshake will use Netty’s built-in thread pool. However, some other parts of this class still use the business-layer–created defaultEventExecutorGroup. In this case, Netty’s codec may behave abnormally.
Steps to Reproduce
- Set serverNettyWorkerGroupEnable to false.
- Decoding fails / throws errors on some connections.
What Did You Expect to See?
All data received by the server can be encoded and decoded correctly.
What Did You See Instead?
Encoding/decoding is abnormal for data received by some servers.
Additional Context
No response