Skip to content

Conversation

@mbien
Copy link
Member

@mbien mbien commented Sep 30, 2025

This is for the API doc of the NetBeans project.

  • sets --syntax-highlight on JDK 25 and later
  • which enables syntax highlighting for code fragments in {@snippet} tags and <pre><code> elements

API doc for CharSequences as example (compare with NB 27 version.):

image

 - sets '--syntax-highlight' on JDK 25 and later
 - which enables syntax highlighting for code fragments in '{@snippet}'
   tags and '<pre><code>' elements
@mbien mbien added this to the NB28 milestone Sep 30, 2025
@mbien mbien requested a review from ebarboni September 30, 2025 15:41
@mbien mbien added build JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels Sep 30, 2025
Copy link
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
there is lots of over inline styled <pre> present in the javadoc.

maybe using snippet a bit more could make javadoc more readable on code side and on website were there is more span than "code"
https://bits.netbeans.org/dev/javadoc/org-openide-util/org/openide/util/doc-files/api.html

@mbien
Copy link
Member Author

mbien commented Oct 1, 2025

it doesn't have to be a snippet I think, it should also handle <pre><code> sections I believe - that is what the javadoc --help doc says at least.

https://bits.netbeans.org/dev/javadoc/org-openide-util/org/openide/util/doc-files/api.html

I checked and the inline-styled sections do still look good. We don't have to change them but we would have the option now during rewrites/updates.

merging.

@mbien mbien merged commit b2b7fa7 into apache:master Oct 1, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build JavaDoc [ci] enable java/javadoc tests and build-javadoc target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants