LSP: Attach missing sources when computing completion docs. #8858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalek
added
Java
MartinBalin
approved these changes
Sep 23, 2025
lahodaj
reviewed
Sep 23, 2025
| if (root != null) { | ||
| CompletableFuture<String> future = new CompletableFuture<>(); | ||
| try { | ||
| SourceJavadocAttacher.attachSources(root.toURL(), new SourceJavadocAttacher.AttachmentListener() { |
Contributor
There was a problem hiding this comment.
Hmmm, just to check - do the attachers run asynchronously? I was trying to look at the sources, and it appears there may be a lot of work happening synchronously, but I am not sure.
Contributor
Author
There was a problem hiding this comment.
The whole computation is performed asynchronously in the TextDocumentServiceImpl.WORKER thread.
donphelix
suggested changes
Sep 29, 2025
java/java.editor/src/org/netbeans/modules/editor/java/JavaCompletionCollector.java
Show resolved
Hide resolved
dbalek
force-pushed
the
dbalek/attach-sources-for-cc-javadoc
branch
from
6545e52 to
0a6eac2
Compare
Contributor
|
I believe this can be now merged? |
lahodaj
approved these changes
Oct 8, 2025
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me - thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing Javadoc for completion items in language server, try to assign class sources automatically if they are missing.