Improve maven goal re-run property handling and UI #8826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Maven
mbien
force-pushed
the
improve-maven-rerun-prop-handling
branch
from
68c27e1 to
f041ab2
Compare
Member
Author
|
@jglick wondering if you are available for more reviews, you likely helped developing maven support back then. |
jglick
reviewed
Sep 22, 2025
java/maven/src/org/netbeans/modules/maven/execute/model/NetbeansActionMapping.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Sep 22, 2025
| Object retValue = DialogDisplayer.getDefault().notify(dd); | ||
| if (retValue == DialogDescriptor.OK_OPTION) { | ||
| pnl.applyValues(mapping); | ||
| maps.getActions().remove(mapping); // deduplicate |
Member
Author
There was a problem hiding this comment.
no, this is just convenience that the same item isn't repeatedly stored in history if you re-run it. marked the main fix via comment
mbien
commented
Sep 22, 2025
Comment on lines
+204
to
+217
| // clear props in case of removal or changed order | ||
| for (String prop : new ArrayList<>(rc.getProperties().keySet())) { | ||
| rc.setProperty(prop, null); | ||
| } | ||
| PropertySplitter split = new PropertySplitter(epProperties.getText()); | ||
| String token = split.nextPair(); | ||
| while (token != null) { | ||
| String[] prp = StringUtils.split(token, "=", 2); //NOI18N | ||
| if (prp.length == 2) { | ||
| String[] prp = token.split("=", 2); //NOI18N | ||
| if (prp.length == 2 && !prp[0].isBlank()) { | ||
| rc.setProperty(prp[0], prp[1]); | ||
| } | ||
| token = split.nextPair(); | ||
| } | ||
|
|
Member
Author
|
thanks a lot for reviewing! will switch to the suggested |
make sure that properties are correctly removed when removed by the user and that they are set in the specified order UI: - renamed "remember as" to "save as", since it persists it to the project config - don't show save-as and history UI in re-run action, since those were only implemented for the run-goal action - avoid storing repeated runs in history - made the goal customizer panel slightly larger (similer to the ant sibling) - minor code improvements
mbien
force-pushed
the
improve-maven-rerun-prop-handling
branch
from
f041ab2 to
bb5b83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that properties are correctly removed when removed by the user and that they are set in the specified order
UI:
fixes #5251