Skip to content

Conversation

@myatt83
Copy link
Contributor

@myatt83 myatt83 commented Sep 8, 2025

Trivial : fix small typos in javadoc / comments
Exception message: Fix typo in error thrown in IOException in harness/nbjunit/src/org/netbeans/junit/Manager.java


Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@mbien mbien added Code cleanup Label for cleanup done on the Netbeans IDE doc Documentation related PRs Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) enterprise [ci] enable enterprise job labels Sep 8, 2025
@mbien
Copy link
Member

mbien commented Sep 8, 2025

I think you can add #8801 to this PR and squash everything to one commit with a short message (feel free to force push).

We merge PRs in this repo when they are ready as-is without letting github squash them so the squashing has to happen manually before merge.

@myatt83
Copy link
Contributor Author

myatt83 commented Sep 8, 2025

Added fixes from #8801 per mbien's advice. will cancel 8801

@myatt83 myatt83 mentioned this pull request Sep 8, 2025
4 tasks
@mbien mbien changed the title Patch 2025-09-08-01 fix typos Fix some typos in comments, doc and messages Sep 8, 2025
@mbien mbien added this to the NB28 milestone Sep 8, 2025
@mbien
Copy link
Member

mbien commented Sep 9, 2025

@myatt83 thanks! Would you like to squash the commits or should I do that?

@mbien
Copy link
Member

mbien commented Sep 9, 2025

I will squash/rebase and force push so that this can get in before some other change causes merge conflicts

@mbien mbien force-pushed the PATCH-2025-09-08-01-Fix-typos branch from 729c719 to 22cf52b Compare September 9, 2025 22:46
@mbien
Copy link
Member

mbien commented Sep 9, 2025

thanks and congrats on your first contribution @myatt83 !

will merge once tests are green

@mbien mbien merged commit 332ec88 into apache:master Sep 10, 2025
137 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code cleanup Label for cleanup done on the Netbeans IDE doc Documentation related PRs enterprise [ci] enable enterprise job Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants