-
Notifications
You must be signed in to change notification settings - Fork 915
Fix incorrect Maven coordinates in binariesembedded-list (jspecify & guice)
#8754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mbien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, could you squash the two commits?
42c76ff to
ecaf75c
Compare
|
@jGauravGupta thanks for the fixes. Btw how did you notice that the coordinates were not correct? |
|
The project failed to build with RELEASE270: Commit reference: So I tweaked the configuration as follows: |
|
thanks for sharing. This can help those who run into the same issue. We should think about validating those coordinates during update. Will try to come up with something next time. |
This PR corrects two Maven coordinates in
java/maven.embedder/external/binariesembedded-list.Changes:
Notes
These corrections align the coordinates with Maven Central and prevent potential build or dependency resolution issues.