Skip to content

Conversation

@jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Aug 22, 2025

This PR corrects two Maven coordinates in
java/maven.embedder/external/binariesembedded-list.

Changes:

  1. JSpecify

  1. Guice

Notes

These corrections align the coordinates with Maven Central and prevent potential build or dependency resolution issues.

@jGauravGupta jGauravGupta requested a review from mbien August 22, 2025 17:58
@mbien mbien added the Maven [ci] enable "build tools" tests label Aug 22, 2025
@mbien mbien added this to the NB28 milestone Aug 22, 2025
@apache apache locked and limited conversation to collaborators Aug 22, 2025
@apache apache unlocked this conversation Aug 22, 2025
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, could you squash the two commits?

@jGauravGupta jGauravGupta force-pushed the binariesembedded-list branch from 42c76ff to ecaf75c Compare August 25, 2025 07:43
@mbien mbien merged commit 4240428 into apache:master Aug 26, 2025
33 checks passed
@mbien
Copy link
Member

mbien commented Aug 26, 2025

@jGauravGupta thanks for the fixes. Btw how did you notice that the coordinates were not correct?

@jGauravGupta
Copy link
Contributor Author

jGauravGupta commented Aug 26, 2025

The project failed to build with RELEASE270:
🔗 https://github.com/jeddict/jeddict-ai

Failed to read artifact descriptor for com.google.inject:guice:jar:5.1.0-classes
	Caused by: The following artifacts could not be resolved: com.google.inject:guice:pom:5.1.0-classes (absent): Could not transfer artifact com.google.inject:guice:pom:5.1.0-classes from/to maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: [netbeans-modules (http://bits.netbeans.org/maven2/, default, releases+snapshots)]

Failed to read artifact descriptor for org.jspecify.jspecify:jspecify:jar:1.0.0
	Caused by: The following artifacts could not be resolved: org.jspecify.jspecify:jspecify:pom:1.0.0 (absent): Could not transfer artifact org.jspecify.jspecify:jspecify:pom:1.0.0 from/to maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: [netbeans-modules (http://bits.netbeans.org/maven2/, default, releases+snapshots)]

Commit reference:
🔗 jeddict/jeddict-ai@0c6bafa

So I tweaked the configuration as follows:

<dependencyManagement>
    <dependencies>
        <dependency>
            <groupId>com.google.inject</groupId>
            <artifactId>guice</artifactId>
            <version>5.1.0</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>org.netbeans.modules</groupId>
            <artifactId>org-netbeans-modules-maven-embedder</artifactId>
            <version>${netbeans.version}</version>
            <exclusions>
                <exclusion>
                    <groupId>org.jspecify.jspecify</groupId>
                    <artifactId>jspecify</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
    </dependencies>
</dependencyManagement>

@mbien
Copy link
Member

mbien commented Aug 26, 2025

thanks for sharing. This can help those who run into the same issue.

We should think about validating those coordinates during update. Will try to come up with something next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maven [ci] enable "build tools" tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants