Skip to content

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Aug 8, 2025

The source path for jtreg tests is inferred (among other things) from the package clause. But, this may lead to computation of weird source roots that are outside of the test directory. This PR is striving to not follow the package clause if:

  • the directory structure does not match the package clause
  • the inferred source root would be outside of the specific test directory

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

…tructure, or that lead outside of test root.
@lahodaj lahodaj added this to the NB28 milestone Aug 8, 2025
@lahodaj lahodaj requested a review from dbalek August 8, 2025 12:08
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Aug 8, 2025
@lahodaj lahodaj merged commit 3fef97a into apache:master Aug 13, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants