Fixing problems related to create element fixes.

[lahodaj]

Fixing several problems related to "create element" fixes (like "Add local variable"):

• consider code:

for (it = Set.of().iterator()) {}

currently, there's a fix that offers to add a local variable, but adds it above the for. This PR adds Create for init variable, which adds the variable to the for init.

• correct detection of target types for switch expressions (yield or case directly).
• fix for: NETBEANS-4304 / https://github.com/mbien/nb-reprorepo/blob/master/tinybugs/src/main/java/fixed/in28/bugs/createmethod/CreateMethodWrongReturnType.java

---

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

1. Was this PR correctly labeled, did the right tests run? When did they run?
2. Is this PR squashed?
3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

[mbien]

this would close NETBEANS-4304 on old jira

[mbien]

test data of

test117431: org.netbeans.modules.java.hints.errors.CreateElementTest

might need adjustment

expected:
<[CreateFieldFix:ii:org.netbeans.test.java.hints.Bug117431:int:[private, static], AddParameterOrLocalFix:ii:int:LOCAL_VARIABLE, AddParameterOrLocalFix:ii:int:PARAMETER]>
but was:
<[CreateFieldFix:ii:org.netbeans.test.java.hints.Bug117431:int:[private, static], AddParameterOrLocalFix:ii:int:OTHER, AddParameterOrLocalFix:ii:int:LOCAL_VARIABLE, AddParameterOrLocalFix:ii:int:PARAMETER]>

[lahodaj]

test data of

test117431: org.netbeans.modules.java.hints.errors.CreateElementTest

might need adjustment

expected:
<[CreateFieldFix:ii:org.netbeans.test.java.hints.Bug117431:int:[private, static], AddParameterOrLocalFix:ii:int:LOCAL_VARIABLE, AddParameterOrLocalFix:ii:int:PARAMETER]>
but was:
<[CreateFieldFix:ii:org.netbeans.test.java.hints.Bug117431:int:[private, static], AddParameterOrLocalFix:ii:int:OTHER, AddParameterOrLocalFix:ii:int:LOCAL_VARIABLE, AddParameterOrLocalFix:ii:int:PARAMETER]>

Right, thanks&sorry. (Hopefully) fixed inline.

[mbien]

looks good