Skip to content

Conversation

@makiam
Copy link
Contributor

@makiam makiam commented Aug 5, 2025

Add extra file extensions support for Groovy

Fix for #7106


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Signed-off-by: Maksim Khramov <maxtemplaar@gmail.com>
@mbien mbien added Groovy ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Aug 6, 2025
@mbien mbien linked an issue Aug 6, 2025 that may be closed by this pull request
@mbien mbien added this to the NB28 milestone Aug 6, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sane, having 4 different endings for a single language looks insane. But ok.

@apache apache locked and limited conversation to collaborators Aug 14, 2025
@apache apache unlocked this conversation Aug 14, 2025
@matthiasblaesing
Copy link
Contributor

Merging, thank you.

@matthiasblaesing matthiasblaesing merged commit 1e51daa into apache:master Aug 14, 2025
56 of 63 checks passed
@makiam makiam deleted the groovy-extra-extensions-support branch August 14, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Groovy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NB 21 doesn't support 'gvy' and 'gy' extensions for Groovy

3 participants