Updating net.java.html library to version 1.8.2. #8658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalek
added
Java
Contributor
|
There is way more files to be updated: https://github.com/apache/netbeans/pull/4040/commits/749f585985b4709d19fe257cb76525345e31e7c4At least in #4040 you updated way more external projects. All of them should be bumped to 1.8.216. 7. 2025 v 13:27, Dusan Balek ***@***.***>:
@dbalek requested your review on: #8658 Updating net.java.html library to version 1.8.2..
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
dbalek
force-pushed
the
dbalek/net.java.html-update
branch
3 times, most recently
from
63c37dd to
49b725e
Compare
dbalek
force-pushed
the
dbalek/net.java.html-update
branch
from
49b725e to
d7b2d4d
Compare
jtulach
approved these changes
Jul 24, 2025
Contributor
jtulach
left a comment
jtulach
left a comment
There was a problem hiding this comment.
- the JARs dependencies are updated
- the CI is green
- the PR cannot be bad
- great idea with the workaround bogus manifest
.javabuild time file! - consider PR to update the upstream
| <import file="../../nbbuild/templates/projectized.xml"/> | ||
| <target name="jar"/> | ||
| <target name="release" depends="projectized.release"> | ||
| <java sourcefile="scripts/WorkaroundBogusManifest.java" |
Contributor
There was a problem hiding this comment.
- Writing build script in Java. That's cute!
|
|
||
| /* | ||
| * The OSGi metadata of the net.java.html.boot require org.objectweb.asm; version="[5.0.0,6.0.0), | ||
| * even though the code has shaded-in version of ASM. And this ancient version of ASM is not |
Contributor
There was a problem hiding this comment.
Do you want to create a PR for http://github.com/apache/netbeans-html4j to remove the dependency in next release properly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
net.java.htmllibrary to version 1.8.2.