Skip to content

Conversation

@neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Jun 26, 2025

Jenkins build currently reporting a disallowed external link in Javadoc due to link to https://services.gradle.org/versions/current in #8606

This is not picked up in the GitHub build - add report to output before fixing.

Fix to allow all links to services.gradle.org - good possibility we'll want to link to other things on there in future.

Also fixes incorrect and invalid JNA link and information in Javadoc I noticed while addressing this.

@neilcsmith-net neilcsmith-net requested a review from mbien June 26, 2025 09:51
@neilcsmith-net neilcsmith-net added the JavaDoc [ci] enable java/javadoc tests and build-javadoc target label Jun 26, 2025
@neilcsmith-net neilcsmith-net marked this pull request as draft June 26, 2025 09:51
@mbien mbien added the CI continuous integration changes label Jun 26, 2025
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@neilcsmith-net neilcsmith-net requested a review from ebarboni June 26, 2025 10:42
@neilcsmith-net neilcsmith-net marked this pull request as ready for review June 26, 2025 11:34
Copy link
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM according to the filechange, checks are bugged on my ui

@neilcsmith-net neilcsmith-net marked this pull request as draft July 9, 2025 14:57
@neilcsmith-net neilcsmith-net force-pushed the javadoc-external-links branch from 28873dd to f5ba89e Compare July 9, 2025 16:18
@neilcsmith-net neilcsmith-net requested review from ebarboni and mbien July 9, 2025 16:20
@neilcsmith-net neilcsmith-net force-pushed the javadoc-external-links branch from f5ba89e to f909ca3 Compare July 9, 2025 17:00
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed in a good way

@neilcsmith-net neilcsmith-net marked this pull request as ready for review July 10, 2025 08:42
@neilcsmith-net
Copy link
Member Author

OK, cherry picked the original fixes on top. Let's check these now pass. Thanks @mbien

Copy link
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilcsmith-net neilcsmith-net merged commit bdfbf14 into apache:master Jul 10, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration changes JavaDoc [ci] enable java/javadoc tests and build-javadoc target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants