-
Notifications
You must be signed in to change notification settings - Fork 915
Fix Javadoc external link errors #8625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Javadoc external link errors #8625
Conversation
mbien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
ebarboni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM according to the filechange, checks are bugged on my ui
28873dd to
f5ba89e
Compare
f5ba89e to
f909ca3
Compare
mbien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed in a good way
|
OK, cherry picked the original fixes on top. Let's check these now pass. Thanks @mbien |
ebarboni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins build currently reporting a disallowed external link in Javadoc due to link to https://services.gradle.org/versions/current in #8606
This is not picked up in the GitHub build - add report to output before fixing.
Fix to allow all links to services.gradle.org - good possibility we'll want to link to other things on there in future.
Also fixes incorrect and invalid JNA link and information in Javadoc I noticed while addressing this.