TreeRuleTestBase: disable slow inherited tests #8602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
Member
Author
|
planning to merge this soon |
those test cases were very slow and inherited down to many other test classes. this made running hint tests slow from the IDE.
mbien
force-pushed
the
disable-slow-hint-tests
branch
from
9876f1b to
6ca94ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those test cases were very slow and inherited down to many other test classes (~10).
this made running hint tests slow from within the IDE (can create the impression that something is stuck and makes no progress).
@lahodaj we chatted about those tests a while ago on slack. Do you think they are still useful or should I remove them completely?