Cleanup parsing.lucene module and fix deprecations #8590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Code cleanup
1 task
mbien
force-pushed
the
lucene-parsing-cleanup
branch
from
da56a2c to
2eeaf73
Compare
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Overall this looks sane to me. I don't agree with everything (for example String#format is in my eyes much more readable than its hot new cousing String#formatted), but I think this is still an improvement.
However at at least one location (see inline comment), I think the API switch changed semantics of the code.
ide/parsing.lucene/src/org/netbeans/modules/parsing/lucene/MemoryIndex.java
Show resolved
Hide resolved
mbien
force-pushed
the
lucene-parsing-cleanup
branch
from
2eeaf73 to
52955b6
Compare
mbien
commented
Jun 22, 2025
ide/parsing.lucene/src/org/netbeans/modules/parsing/lucene/MemoryIndex.java
Outdated
Show resolved
Hide resolved
Member
Author
|
thanks for reviews, I want to simplify the |
- all lucene deprecations fixed - javac warnings fixed - JDK 17 language level and other cleanup
mbien
force-pushed
the
lucene-parsing-cleanup
branch
2 times, most recently
from
11de9da to
0e567c7
Compare
mbien
commented
Jun 23, 2025
Comment on lines
-986
to
963
| if (reader != null) { | ||
| final IndexReader newReader = IndexReader.openIfChanged(reader); | ||
| IndexReader newReader = IndexReader.openIfChanged(reader); | ||
| if (newReader != null) { | ||
| reader.close(); | ||
| reader = newReader; |
Member
Author
There was a problem hiding this comment.
both impls are now the same, this is LuceneIndex
Comment on lines
-307
to
296
| if (cachedReader != null) { | ||
| final IndexReader newReader = cachedReader.reopen(); | ||
| if (newReader != cachedReader) { | ||
| IndexReader newReader = IndexReader.openIfChanged(cachedReader); | ||
| if (newReader != null) { | ||
| cachedReader.close(); | ||
| cachedReader = newReader; |
mbien
removed
the
ci:dev-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene 4.0 breaks API which makes an upgrade a bit tricky since not much builds after that. This moves some of the work to 3.6.2 while tests are still working as attempt to make #8384 easier.