Skip to content

Conversation

@dukescript
Copy link
Contributor

@dukescript dukescript commented Jun 15, 2025

This PR fixes #8587 by upgrading the maven archetypes version from 0.23 to 0.41. The change affects project creation in offline mode. When online the wizard automatically uses the latest version:
https://mvnrepository.com/artifact/com.dukescript.archetype/pom/0.41
https://mvnrepository.com/artifact/com.dukescript.archetype/crud4j-archetype/0.41
https://mvnrepository.com/artifact/com.dukescript.archetype/visual-archetype/0.41


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@neilcsmith-net
Copy link
Member

Please don't open issues if you have a PR ready to submit.

As you're on the PMC, please make sure your GitHub account is currently linked up with your Apache account.

@jtulach jtulach self-requested a review June 16, 2025 05:56
Copy link
Contributor

@jtulach jtulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see some activity over all those years. Thanks.

@jtulach jtulach changed the title refs #8587 upgrade offline version of html-ui archetypes to 0.41 Upgrade offline version of html-ui archetypes to 0.41 Jun 17, 2025
@jtulach
Copy link
Contributor

jtulach commented Jun 17, 2025

Is this PR squashed?

If the CI checks turn out green, I'd like to merge this single commit by pressing "Merge pull request".

  • Because it is a single commit, there is no need to squash, right?
  • The commit info mentions Toni Epple and one of his email addresses. It seems acceptable to me.

Opinions? Objections? References to guidelines I'd violate by pressing the "Merge pull request" button?

@jtulach jtulach added Maven [ci] enable "build tools" tests JavaFX [ci] enable JavaFX job labels Jun 17, 2025
@dukescript
Copy link
Contributor Author

Please don't open issues if you have a PR ready to submit.

As you're on the PMC, please make sure your GitHub account is currently linked up with your Apache account.

I will try to remember. In my other projects it is "due process" to never create a PR without creating/referencing an issue.

@eppleton eppleton force-pushed the update-html-ui-maven-archetype-versions branch from fff53e4 to 0abab2a Compare June 17, 2025 08:22
@mbien mbien added the Upgrade Library Library (Dependency) Upgrade label Jun 17, 2025
@mbien mbien added this to the NB27 milestone Jun 17, 2025
@mbien
Copy link
Member

mbien commented Jun 18, 2025

Opinions? Objections? References to guidelines I'd violate by pressing the "Merge pull request" button?

@jtulach the patch looks fine to me (but I haven't tested it!). Whether thats the right account (doesn't look like its linked to apache?) or email i don't really know. But for the small changeset it probably isn't super important. (Merging anonymous contributions is something we should avoid though)

@jtulach
Copy link
Contributor

jtulach commented Jun 20, 2025

https://github.com/apache/netbeans/commit/0abab2a2f0c34224f8dcafdf7079632e787ef36e.patch now indicates

From 0abab2a2f0c34224f8dcafdf7079632e787ef36e Mon Sep 17 00:00:00 2001
From: Anton Epple <toni.epple@eppleton.de>
Date: Sun, 15 Jun 2025 08:29:37 +0200
Subject: [PATCH] refs #8587 upgrade offline version of html-ui archetypes to 0.41

Toni seems to be listed at https://people.apache.org/phonebook.html?unix=netbeans - I ask him to merge himself.

@neilcsmith-net
Copy link
Member

Sure, Toni is a committer and on the PMC, so asking him to merge himself would prove the merging account is correctly linked up. I commented primarily because I noticed the CI needed manually starting. It should start automatically if the PR is opened by a committer.

@eppleton eppleton merged commit e80ec88 into apache:master Jun 23, 2025
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaFX [ci] enable JavaFX job Maven [ci] enable "build tools" tests Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML UI wizard uses outdated archetype version when offline

5 participants