-
Notifications
You must be signed in to change notification settings - Fork 915
Upgrade offline version of html-ui archetypes to 0.41 #8588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade offline version of html-ui archetypes to 0.41 #8588
Conversation
|
Please don't open issues if you have a PR ready to submit. As you're on the PMC, please make sure your GitHub account is currently linked up with your Apache account. |
jtulach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see some activity over all those years. Thanks.
If the CI checks turn out green, I'd like to merge this single commit by pressing "Merge pull request".
Opinions? Objections? References to guidelines I'd violate by pressing the "Merge pull request" button? |
I will try to remember. In my other projects it is "due process" to never create a PR without creating/referencing an issue. |
fff53e4 to
0abab2a
Compare
@jtulach the patch looks fine to me (but I haven't tested it!). Whether thats the right account (doesn't look like its linked to apache?) or email i don't really know. But for the small changeset it probably isn't super important. (Merging anonymous contributions is something we should avoid though) |
|
https://github.com/apache/netbeans/commit/0abab2a2f0c34224f8dcafdf7079632e787ef36e.patch now indicates Toni seems to be listed at https://people.apache.org/phonebook.html?unix=netbeans - I ask him to merge himself. |
|
Sure, Toni is a committer and on the PMC, so asking him to merge himself would prove the merging account is correctly linked up. I commented primarily because I noticed the CI needed manually starting. It should start automatically if the PR is opened by a committer. |
This PR fixes #8587 by upgrading the maven archetypes version from 0.23 to 0.41. The change affects project creation in offline mode. When online the wizard automatically uses the latest version:
https://mvnrepository.com/artifact/com.dukescript.archetype/pom/0.41
https://mvnrepository.com/artifact/com.dukescript.archetype/crud4j-archetype/0.41
https://mvnrepository.com/artifact/com.dukescript.archetype/visual-archetype/0.41
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)