Fix mvnd test session regression #8539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test session was never set to finished when EventSpy was not active. EventSpy is currently disabled when multi threaded builds are detected and mvnd is multi threaded by default. This caused the test window to think tests are still running. This adds a fallback to signal session completion.
mbien
added
Maven
This was referenced May 28, 2025
matthiasblaesing
approved these changes
Jun 1, 2025
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Only eyeballed this, but looks sane to me.
#3995 might need to touch this area too, so it might be good to get the fix in.
Contributor
|
Verifying that solution works. while working with the file JUnitOutputListenerProvider.java I noticed a change relevant to this issue, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test session was never set to finished when EventSpy was not active. EventSpy is currently disabled when multi threaded builds are detected and mvnd is multi threaded by default (unless e.g
-Dmvnd.serialis set). This caused the test window to think tests are still running.This adds a fallback to signal session completion.
see apache/maven-mvnd#1333
second regression since #7979 (first: #8433)