Variable-hides-field hint optimization #8525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
commented
May 23, 2025
Comment on lines
+91
to
+96
| Elements elements = compilationInfo.getElements(); | ||
| for (Element field : getAllMembers(compilationInfo, te)) { | ||
| if (stop) { | ||
| return null; | ||
| } | ||
| if (compilationInfo.getElements().hides(el, field)) { | ||
| if (elements.hides(el, field)) { |
Member
Author
|
planning to merge this one soon since its one of the smaller ones |
mbien
force-pushed
the
faster-hides-field-hint
branch
from
1e012d6 to
23deda2
Compare
compilationinfo.getElements() in inner loop prevented the JVM from inlining calls into the loop body. Moving it out of the loop improves performance by 10x in files with many fields. rest is cleanup
mbien
force-pushed
the
faster-hides-field-hint
branch
from
23deda2 to
d1258e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compilationinfo.getElements() in inner loop prevented the JVM from inlining calls into the loop body. Moving it out of the loop improves hint performance by 10x in files with many fields.
rest is cleanup