Cache ClassIndex during UnusedDetector search #8437
Merged
+56
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
force-pushed
the
unused-pkgprivate-performance
branch
from
68072fe to
97686fc
Compare
mbien
changed the title
lahodaj
reviewed
May 5, 2025
java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/UnusedDetector.java
Outdated
Show resolved
Hide resolved
lahodaj
approved these changes
May 5, 2025
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me, with some suggestions inline.
java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/UnusedDetector.java
Outdated
Show resolved
Hide resolved
mbien
force-pushed
the
unused-pkgprivate-performance
branch
from
97686fc to
3fcc547
Compare
Member
Author
|
the key is now a constant and changed the retention policy from |
- optimizes the isUnusedInPkg() code path - one pkg private element comes rarely alone, getting the ClassIndex for the FileObject can be expensive - compute it only once
Member
Author
|
going to rebase and then merge once green since RC3 was synced. Thanks for the review! |
mbien
force-pushed
the
unused-pkgprivate-performance
branch
from
3fcc547 to
9bacf23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isUnusedInPkg()code pathClassIndexfor theFileObjectcan be expensiverunning a synthetic test file with 10k package private elements
findUnused()without caching (in ms):ClassIndexcomputed once:note: the method is called twice on first file open, both measurements are shown since the code paths are different.
This might be potentially solvable without putting anything into the cache and making
UnusedDetectoran instance object.