Implement Preferences cache for java hints. #8418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
force-pushed
the
java-hints-preferences-cache
branch
2 times, most recently
from
c775f65 to
3d5f914
Compare
Member
Author
|
although this seems to work fine, this is not as clean as it could be IMO. Low level code like hints could ideally have an immutable copy of the hint settings, instead of having to query mutable configuration directly. |
Some hints are invoked very frequently by the scanner (analog to an inner loop). Querying Preferences from hot code can be expensive. Preferences were also used outside of the hint implementations, for example for isEnabled() or getSeverity() queries before invoking the actual hint. This isn't visible in the hint metrics log. Caching Preferences in the hint context covers both usages. The cache is disposed together with the hint processing task.
mbien
force-pushed
the
java-hints-preferences-cache
branch
from
3d5f914 to
872a144
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hints are invoked very frequently by the scanner (analog to an inner loop). Querying Preferences from hot code can be expensive.
Preferences were also used outside of the hint implementation, for example for
isEnabled()orgetSeverity()queries before invoking the actual hint. This isn't visible in the hint metrics log.Caching Preferences in the hint context covers both usages. The cache is disposed together with the hint processing task.
pink sections mark Preferences queries during hint computation.
with cache enabled they are gone
