Skip to content

Conversation

@mbien
Copy link
Member

@mbien mbien commented Apr 11, 2025

smoke tested on gnome and everything worked as expected (rounded window buttons look nice too)

fixes #8366

@mbien mbien added Upgrade Library Library (Dependency) Upgrade Look and Feel UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Apr 11, 2025
@mbien mbien added this to the NB26 milestone Apr 11, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Looks" sane to me. I suggest to add the mapping for the native linux-arm64 variant though. See the comment about the added library variant in the release notes.

--- a/platform/libs.flatlaf/nbproject/project.properties
+++ b/platform/libs.flatlaf/nbproject/project.properties
@@ -42,10 +42,12 @@
 release.external/flatlaf-3.6.jar!/com/formdev/flatlaf/natives/libflatlaf-macos-arm64.dylib=modules/lib/libflatlaf-macos-arm64.dylib
 release.external/flatlaf-3.6.jar!/com/formdev/flatlaf/natives/libflatlaf-macos-x86_64.dylib=modules/lib/libflatlaf-macos-x86_64.dylib
 release.external/flatlaf-3.6.jar!/com/formdev/flatlaf/natives/libflatlaf-linux-x86_64.so=modules/lib/libflatlaf-linux-x86_64.so
+release.external/flatlaf-3.6.jar!/com/formdev/flatlaf/natives/libflatlaf-linux-arm64.so=modules/lib/libflatlaf-linux-arm64.so
 jnlp.verify.excludes=\
     modules/lib/flatlaf-windows-x86.dll,\
     modules/lib/flatlaf-windows-x86_64.dll,\
     modules/lib/flatlaf-windows-arm64.dll,\
     modules/lib/libflatlaf-macos-arm64.dylib,\
     modules/lib/libflatlaf-macos-x86_64.dylib,\
-    modules/lib/libflatlaf-linux-x86_64.so
+    modules/lib/libflatlaf-linux-x86_64.so,\
+    modules/lib/libflatlaf-linux-arm64.so

 - small feature and bugfix release
 - added arm64 linux binary
@mbien
Copy link
Member Author

mbien commented Apr 13, 2025

added the arm lib config

@mbien mbien merged commit 89692d1 into apache:master Apr 13, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Look and Feel UI User Interface Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collapsed Menus Can't Be Expanded

2 participants