CSS: Add support for container query length units (cqw, cqh, cqi, cqb, cqmin, cqmax) #8405
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Thank you. The change looks right. Would you please:
- add tests for the new length units into
org.netbeans.modules.css.lib.api.properties.TokenAcceptorsTest#testLengthAcceptor() - I suggest to adjust the commit message to:
CSS: Add support for container query length units (cqw, cqh, cqi, cqb, cqmin, cqmax)
Closes: #8364
Contributor
Author
Cool. |
…, cqmin, cqmax) Closes: apache#8364
haidubogdan
force-pushed
the
t_issue_8364_css_container_units
branch
from
464bff6 to
09caa3b
Compare
Contributor
|
@haidubogdan thank you! Merging. |
matthiasblaesing
changed the title
Member
|
@matthiasblaesing please make sure there's a milestone on all merged PRs, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #8364
I have a pull request with the included container units :
"cqw", "cqh", "cqi", "cqb", "cqmin", "cqmax"
Before:
After:
