Improving LSP client, not crashing cpplite.editor when ccls/clangd is not specified. #8372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
approved these changes
Mar 30, 2025
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Only eyeballed this, but looks sane to me. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three smallish improvements here:
cpplite.editor, when one ofcclsorclangdis not specified in the settings, the path for the given server isnull, and thisnullis sent toList.of, butList.ofis null averse, and throws an exception, breaking the CPPLite C/C++ support (as even the one server that is specified won't be able to run, as the exception happens too soon). This PR proposes one way to fix that, but there are other ways.lsp.client, if the server does not provide document symbol provider, don't use it for breadcrumbs (otherwise it tends to fail with an exception)lsp.client,CompletionItem.getLabelDetails().getDescription()may benull- account for that.