Icon fix: Interface and Abstract class are not distinguished #8362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… icon. (Regression when SVG icons were introduced.)
mbien
added
Java
Contributor
Author
|
Ah, forgot the labels... thanks! |
matthiasblaesing
approved these changes
Mar 27, 2025
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks good to me and works:
Thank you.
Contributor
Author
|
Thanks for reviewing, will merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported at #8358 , the icons for abstract classes and interfaces had regressed to becoming the regular class icon. This was caused by the introduction of SVG icons for these and many others in #8083 .
The bug was due to a special piece of logic in JavaNode that actually checked for the file name of the icon. Since the file name now ends with ".svg", the behavior changed.
I could not immediately find any other similar cases.