Adjust focus behavior when closing the last editor in a window mode #8317
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than the 'editor' one, move the focus to the 'editor' mode in preference to other modes (rather than e.g. the Output pane or Projects tab).
eirikbakke
added
Editor
Platform
matthiasblaesing
approved these changes
Mar 30, 2025
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Seems to be in line with the original intention, looks sane to me and in my test I could follow the stated example. Thanks.
Contributor
Author
|
Thanks for reviewing! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user closes the last TopComponent in a window system mode other than the 'editor' one, move the focus to the 'editor' mode in preference to other modes (rather than e.g. the Output pane or Projects tab).
For example, in the following screenshot, if the user has the "Mavenproject1.java" editor selected, and then presses Ctrl+W (Command-W on Mac) to close that editor, the focus would previously end up on the Projects tab. With this PR in place, the focus instead goes to the NewClass editor. This is more useful, and consistent with the behavior that happens when the user closes an editor in a mode that have other tabs still open.