Support for OpenJDK hotspot tests. #8260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahodaj
added
the
Java
Contributor
Author
|
I have seen some fairly frequent deadlocks on start with the original patch. I don't think it was directly caused by the change here, as I think I've seen a deadlock like that even before, but this change might have made the deadlock much more probable. The deadlock was Project mutex -> SourceImpl monitor (when the project properties were set) vs SourceImpl monitor -> Project mutex computing the roots, and querying the properties. The solution for the deadlock proposed here is to only record something changed when the poperties change, and compute on the first access, and limit locking when computing the roots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.