[NETBEANS-8233] When creating a doc comment tree from a full body, avoid the spliting and merging of the body, and simply use the full body, so that the code generator sees the correct, unsplit, full body. #8245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and merging of the body, and simply use the full body, so that the backend sees the correct, unsplit, full body.
lahodaj
added
Java
lahodaj
changed the title
mbien
reviewed
Feb 13, 2025
Member
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
can confirm that this fixes the issue.
I think NB26 is fine for this I agree. It already shipped with NB 24 so it is not a high priority regression IMO. (RC2 will likely also be the last RC since the PR queue is empty atm)
Contributor
Author
|
Anyone willing to review (and possibly Approve) this? Thanks! |
mbien
approved these changes
Feb 25, 2025
Member
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
sure, thanks for fixing the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing the Markdown work, I (IIRC) tried to canonicalize the way doc comment trees are created. But that does not behave sanely - when full body is split into the first sentence and the rest, the text trees might change, and that may then lead to the code generator doing the wrong thing.
Trying to only create the doc comment tree from the full body, if available (it will split internally anyway, but the split trees won't be used by the code gen, I think: the code gen uses full body).
(Not sure if this should go to 26 or 25 - not sure if it can get enough testing, but then this is probably not too dangerous.)