Ant: fix GeneratedFilesHelper CRC cache #8190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Jan 26, 2025
Contributor
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Looks right. Congratulations!
Member
Author
|
thanks for review, planning to merge this after rc2 synced back to master, since this stabilizes CI a bit |
Cache used the xor function of timestamp and size as modification indicator for a CRC cache. This produced frequent collisions esp when timestamp and size were close together between two modifications. example write to a file 3 ms apart which adds 5 bytes: 1737766006001L ^ 208 1737766006004L ^ 213 produces the same value -> thinks there was no modification fix: store both values without combiner function
mbien
force-pushed
the
fix-ant-fileshelper-crc-cache
branch
from
fe97dec to
286e958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache used the xor function of timestamp and size as modification indicator for a CRC cache. This produced frequent collisions esp when timestamp and size were close together between two modifications.
example: write to a file 3 ms apart which added 5 bytes:
produces the same value -> thinks there was no modification -> returns old/wrong CRC value
fix: store both values without combiner function
fixes the first item on #8183
edit: emilianbold/netbeans-releases@fe56d24 close to 21 years old - might be new personal record after #7951 (comment) :).