Remove sortedcontainers dependency #2947
Merged
+1
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geruh
commented
Jan 25, 2026
| completed_futures.add(future) | ||
|
|
||
| bin_results: list[list[ManifestFile]] = [f.result() for f in completed_futures if f.result()] | ||
| bin_results: list[list[ManifestFile]] = [r for f in futures if (r := f.result())] |
Contributor
Author
There was a problem hiding this comment.
We can use a walrus operator to avoid calling .result() twice per future
kevinjqliu
approved these changes
Jan 25, 2026
| completed_futures.add(future) | ||
|
|
||
| bin_results: list[list[ManifestFile]] = [f.result() for f in completed_futures if f.result()] | ||
| bin_results: list[list[ManifestFile]] = [r for f in futures if (r := f.result())] |
Contributor
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2945
Rationale for this change
This PR removes the
SortedContainersdependency. Looking at the behavior of sorted containers we can simplify the logic for merging manigests and collecting the results while maintaining identical behavior.What the logic today was doing:
as_completed()which is out of orderSortedListto maintain order by submissionWhat we do now:
.result()on eachThis shows we must collect the results before the next step. So we can iterate futures directly and call
.result()in order. This blocks the main thread until each future completes, but doesn't block worker threads and they all continue running in parallel.Are these changes tested?
All existing tests pass.
Are there any user-facing changes?
No