Run ruff format in CI #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Evidence this is correctly finding files that do not have ruff formatting applied: https://github.com/apache/datafusion-python/actions/runs/10547368222/job/29219963769?pr=837 |
Member
Author
|
Evidence that it passes when formatting applied: https://github.com/apache/datafusion-python/actions/runs/10547389324/job/29220013949?pr=837 |
Member
Author
|
@Michael-J-Ward This should resolve the formatting issues in my other PR |
Michael-J-Ward
approved these changes
Aug 26, 2024
Member
Author
|
@andygrove Can we merge this in? It’s just white space and CI improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Adds format check for python files to match pre-commit
Rationale for this change
We are getting some commits that are reformatting code. It is likely some users have pre-commit on and some do not. We do currently check ruff, but not ruff format.
What changes are included in this PR?
Enable ruff format in CI.
Apply formatting to 6 files.
Are there any user-facing changes?
None. Just code cleanliness.