Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR adds APIs to clone existing offerings - service, system, network, VPC, backup and update certain parameters of the existing offering.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.46%. Comparing base (5bf869c) to head (3981d42).
⚠️ Report is 63 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (5bf869c) and HEAD (3981d42). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf869c) HEAD (3981d42)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #12357       +/-   ##
=============================================
- Coverage     17.51%    3.46%   -14.05%     
=============================================
  Files          5914      452     -5462     
  Lines        529867    38920   -490947     
  Branches      64722     7327    -57395     
=============================================
- Hits          92782     1347    -91435     
+ Misses       426635    37407   -389228     
+ Partials      10450      166    -10284     
Flag Coverage Δ
uitests 3.46% <ø> (-0.12%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from 62368f3 to 3787aaa Compare January 6, 2026 22:39
@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Jan 7, 2026
@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from a5a9eb4 to bb2e90d Compare January 8, 2026 21:49
@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from bb2e90d to 7fd4567 Compare January 8, 2026 21:52
@boring-cyborg boring-cyborg bot added component:marvin Python Warning... Python code Ahead! labels Jan 9, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
8.2% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make the new if and for blocks separte methods (with clear names please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants